commit 5b45b26b23a30efc2fa5d859f6e1e009c631c55a
author Rico Wind <ricow@google.com> Mon May 13 10:42:07 2019 +0200
committer Rico Wind <ricow@google.com> Mon May 13 08:55:58 2019 +0000
tree d5d88bb20ac88141c818fbc49834ae72a811c9e3
parent e22cda6e0517b3ac3102b3c6df4750e2c1914767

Use a set when calling removeAll

removeAll on an IdentiyHashSet will do contains checks on the passed in collection

This has a massive impact on the runtime of youtube 14, basically cutting the compile time in half.

I will try to grep for more places where we pass a list to a removeAll call on an IdentityHashSet

Bug: 132420434
Change-Id: Iaf183e4f6a61b0d1dae4fb4f19d61ba48ee19330

src/main/java/com/android/tools/r8/shaking/Enqueuer.java

diff --git a/src/main/java/com/android/tools/r8/shaking/Enqueuer.java b/src/main/java/com/android/tools/r8/shaking/Enqueuer.java
index 7582343..57290f9 100644
--- a/src/main/java/com/android/tools/r8/shaking/Enqueuer.java
+++ b/src/main/java/com/android/tools/r8/shaking/Enqueuer.java
@@ -317,7 +317,7 @@
         pinnedItems.stream()
             .filter(DexReference::isDexField)
             .map(DexReference::asDexField)
-            .collect(Collectors.toList()));
+            .collect(Collectors.toSet()));
     return result;
   }