blob: 77190ce9507416bb99903e80100f70e984be7915 [file] [log] [blame]
// Copyright (c) 2019, the R8 project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
package com.android.tools.r8.naming;
import static com.android.tools.r8.utils.codeinspector.Matchers.isPresent;
import static com.android.tools.r8.utils.codeinspector.Matchers.isRenamed;
import static org.hamcrest.CoreMatchers.not;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertEquals;
import com.android.tools.r8.NeverMerge;
import com.android.tools.r8.TestBase;
import com.android.tools.r8.TestParameters;
import com.android.tools.r8.utils.BooleanUtils;
import com.android.tools.r8.utils.StringUtils;
import com.android.tools.r8.utils.codeinspector.ClassSubject;
import com.android.tools.r8.utils.codeinspector.CodeInspector;
import com.android.tools.r8.utils.codeinspector.FieldSubject;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
/**
* Tests that a reserved field name from a given class is taken into account when renaming the
* fields in supertypes of that class.
*/
@RunWith(Parameterized.class)
public class ReservedFieldNameInSubClassTest extends TestBase {
private final TestParameters parameters;
private final boolean reserveName;
@Parameterized.Parameters(name = "{0}, reserve name: {1}")
public static List<Object[]> data() {
return buildParameters(getTestParameters().withAllRuntimes().build(), BooleanUtils.values());
}
public ReservedFieldNameInSubClassTest(TestParameters parameters, boolean reserveName) {
this.parameters = parameters;
this.reserveName = reserveName;
}
@Test
public void test() throws Exception {
String expectedOutput = StringUtils.lines("Hello world!");
CodeInspector inspector =
testForR8(parameters.getBackend())
.addProgramClasses(
TestClass.class, A.class, B.class, C.class, I.class, J.class, K.class)
.enableMergeAnnotations()
.addKeepMainRule(TestClass.class)
.addKeepRules(
reserveName
? "-keepclassmembernames class "
+ C.class.getTypeName()
+ "{ java.lang.String a; }"
: "")
.setMinApi(parameters.getRuntime())
.run(parameters.getRuntime(), TestClass.class)
.assertSuccessWithOutput(expectedOutput)
.inspector();
ClassSubject aClassSubject = inspector.clazz(A.class);
assertThat(aClassSubject, isPresent());
ClassSubject bClassSubject = inspector.clazz(B.class);
assertThat(bClassSubject, isPresent());
ClassSubject cClassSubject = inspector.clazz(C.class);
assertThat(cClassSubject, isPresent());
ClassSubject iClassSubject = inspector.clazz(I.class);
assertThat(iClassSubject, isPresent());
ClassSubject jClassSubject = inspector.clazz(J.class);
assertThat(jClassSubject, isPresent());
ClassSubject kClassSubject = inspector.clazz(K.class);
assertThat(kClassSubject, isPresent());
FieldSubject f1FieldSubject = aClassSubject.uniqueFieldWithName("f1");
assertThat(f1FieldSubject, isPresent());
FieldSubject f2FieldSubject = bClassSubject.uniqueFieldWithName("f2");
assertThat(f2FieldSubject, isPresent());
FieldSubject f3FieldSubject = iClassSubject.uniqueFieldWithName("f3");
assertThat(f3FieldSubject, isPresent());
FieldSubject f4FieldSubject = jClassSubject.uniqueFieldWithName("f4");
assertThat(f4FieldSubject, isPresent());
FieldSubject f5FieldSubject = kClassSubject.uniqueFieldWithName("f5");
assertThat(f5FieldSubject, isPresent());
FieldSubject aFieldSubject = cClassSubject.uniqueFieldWithName("a");
assertThat(aFieldSubject, isPresent());
if (reserveName) {
assertThat(f1FieldSubject, isRenamed());
assertEquals("e", f1FieldSubject.getFinalName());
assertThat(f2FieldSubject, isRenamed());
assertEquals("f", f2FieldSubject.getFinalName());
assertThat(f3FieldSubject, isRenamed());
assertEquals("b", f3FieldSubject.getFinalName());
assertThat(f4FieldSubject, isRenamed());
assertEquals("c", f4FieldSubject.getFinalName());
assertThat(f5FieldSubject, isRenamed());
assertEquals("d", f5FieldSubject.getFinalName());
// B.a should not be renamed because it is not allowed to be minified.
assertThat(aFieldSubject, not(isRenamed()));
} else {
assertThat(f1FieldSubject, isRenamed());
assertEquals("d", f1FieldSubject.getFinalName());
assertThat(f2FieldSubject, isRenamed());
assertEquals("e", f2FieldSubject.getFinalName());
assertThat(f3FieldSubject, isRenamed());
assertEquals("a", f3FieldSubject.getFinalName());
assertThat(f4FieldSubject, isRenamed());
assertEquals("b", f4FieldSubject.getFinalName());
assertThat(f5FieldSubject, isRenamed());
assertEquals("c", f5FieldSubject.getFinalName());
assertThat(aFieldSubject, isRenamed());
assertEquals("f", aFieldSubject.getFinalName());
}
}
@NeverMerge
static class A {
String f1 = "He";
}
@NeverMerge
static class B extends A {
String f2 = "l";
}
@NeverMerge
interface I {
String f3 = System.currentTimeMillis() >= 0 ? "lo" : null;
}
@NeverMerge
interface J extends I {
String f4 = System.currentTimeMillis() >= 0 ? " " : null;
}
@NeverMerge
interface K {
String f5 = System.currentTimeMillis() >= 0 ? "world" : null;
}
static class C extends B implements J, K {
String a = "!";
@Override
public String toString() {
return f1 + f2 + f3 + f4 + f5 + a;
}
}
static class TestClass {
public static void main(String[] args) {
System.out.println(new C());
}
}
}