blob: 85ace0bc225eeff615affec3342028d774007c34 [file] [log] [blame]
// Copyright (c) 2019, the R8 project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
package com.android.tools.r8.resolution;
import static org.hamcrest.CoreMatchers.containsString;
import static org.junit.Assert.assertTrue;
import com.android.tools.r8.R8TestRunResult;
import com.android.tools.r8.TestBase;
import com.android.tools.r8.TestParameters;
import com.android.tools.r8.TestParametersCollection;
import com.android.tools.r8.TestRunResult;
import com.android.tools.r8.TestRuntime;
import com.android.tools.r8.ToolHelper.DexVm;
import com.android.tools.r8.graph.DexMethod;
import com.android.tools.r8.graph.ResolutionResult;
import com.android.tools.r8.shaking.AppInfoWithLiveness;
import com.google.common.collect.ImmutableList;
import java.util.List;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
import org.objectweb.asm.Opcodes;
@RunWith(Parameterized.class)
public class VirtualOverrideOfPrivateStaticMethodWithVirtualParentTest extends TestBase {
public interface I {
default void f() {}
}
public static class Base {
private // Made public using ASM.
void f() {}
}
public static class A extends Base {
private static void f() {}
}
public static class B extends A implements I {}
public static class C extends B {
public void f() {
System.out.println("Called C.f");
}
}
public static class Main {
public static void main(String[] args) {
B b = new C();
b.f();
}
}
public static class BaseDump implements Opcodes {
public static byte[] dump() throws Exception {
return transformer(Base.class).setPublic(Base.class.getDeclaredMethod("f")).transform();
}
}
public static List<Class<?>> CLASSES =
ImmutableList.of(A.class, B.class, C.class, I.class, Main.class);
public static List<byte[]> getDumps() throws Exception {
return ImmutableList.of(BaseDump.dump());
}
private static AppInfoWithLiveness appInfo;
@BeforeClass
public static void computeAppInfo() throws Exception {
appInfo =
computeAppViewWithLiveness(
buildClasses(CLASSES).addClassProgramData(getDumps()).build(), Main.class)
.appInfo();
}
private static DexMethod buildMethod(Class clazz, String name) {
return SingleTargetLookupTest.buildNullaryVoidMethod(clazz, name, appInfo);
}
@Parameters(name = "{0}")
public static TestParametersCollection data() {
return getTestParameters().withAllRuntimes().withAllApiLevels().build();
}
private final TestParameters parameters;
private final DexMethod methodOnA = buildMethod(A.class, "f");
private final DexMethod methodOnB = buildMethod(B.class, "f");
private final DexMethod methodOnC = buildMethod(C.class, "f");
public VirtualOverrideOfPrivateStaticMethodWithVirtualParentTest(TestParameters parameters) {
this.parameters = parameters;
}
@Test
public void testResolution() {
ResolutionResult resolutionResult = appInfo.resolveMethodOnClass(methodOnB.holder, methodOnB);
assertTrue(resolutionResult.isFailedResolution());
}
@Test
public void runJvmAndD8() throws Exception {
TestRunResult<?> runResult;
if (parameters.isCfRuntime()) {
runResult =
testForJvm()
.addProgramClasses(CLASSES)
.addProgramClassFileData(getDumps())
.run(parameters.getRuntime(), Main.class);
} else {
runResult =
testForD8()
.addProgramClasses(CLASSES)
.addProgramClassFileData(getDumps())
.setMinApi(parameters.getApiLevel())
.run(parameters.getRuntime(), Main.class);
}
checkResult(runResult, false);
}
@Test
public void runR8() throws Exception {
R8TestRunResult runResult =
testForR8(parameters.getBackend())
.addProgramClasses(CLASSES)
.addProgramClassFileData(getDumps())
.addKeepMainRule(Main.class)
.setMinApi(parameters.getApiLevel())
.run(parameters.getRuntime(), Main.class);
checkResult(runResult, true);
}
private void checkResult(TestRunResult<?> runResult, boolean isCorrectedByR8) {
if (expectedToIncorrectlyRun(parameters.getRuntime(), isCorrectedByR8)) {
// Do to incorrect resolution, some Art VMs will resolve to Base.f (ignoring A.f) and thus
// virtual dispatch to C.f. See b/140013075.
runResult.assertSuccessWithOutputLines("Called C.f");
} else {
runResult.assertFailureWithErrorThatMatches(containsString(expectedRuntimeError()));
}
}
private boolean expectedToIncorrectlyRun(TestRuntime runtime, boolean isCorrectedByR8) {
return !isCorrectedByR8
&& runtime.isDex()
&& runtime.asDex().getVm().isNewerThan(DexVm.ART_4_4_4_HOST)
&& runtime.asDex().getVm().isOlderThanOrEqual(DexVm.ART_7_0_0_HOST);
}
private String expectedRuntimeError() {
if (parameters.isDexRuntime()
&& parameters.getRuntime().asDex().getVm().isOlderThanOrEqual(DexVm.ART_4_4_4_HOST)) {
return "IncompatibleClassChangeError";
}
return "IllegalAccessError";
}
}