commit | 75183488819a72f1195970d6951ed917926cd7f0 | [log] [tgz] |
---|---|---|
author | Ian Zerny <zerny@google.com> | Wed Apr 20 13:11:46 2022 +0200 |
committer | Ian Zerny <zerny@google.com> | Fri Apr 22 07:12:48 2022 +0000 |
tree | 3fbf5da0b5a9be5639c86d64b17adbfca320fe4a | |
parent | 908f1f58db9b9aa30e228cbd2816e655774d62f4 [diff] |
Add todo for possible valid frames of different length. Bug: b/229826687 Change-Id: I6402493b64bbf28c476a340c6252a0c8765135ca
diff --git a/src/main/java/com/android/tools/r8/cf/code/CfFrameVerificationHelper.java b/src/main/java/com/android/tools/r8/cf/code/CfFrameVerificationHelper.java index c81abe4..a3fc4d1 100644 --- a/src/main/java/com/android/tools/r8/cf/code/CfFrameVerificationHelper.java +++ b/src/main/java/com/android/tools/r8/cf/code/CfFrameVerificationHelper.java
@@ -326,6 +326,7 @@ Int2ReferenceSortedMap<FrameType> destLocals, DexItemFactory factory, BiPredicate<DexType, DexType> isJavaAssignable) { + // TODO(b/229826687): The tail of locals could have top(s) at destination but still be valid. final int localsLastKey = sourceLocals.isEmpty() ? -1 : sourceLocals.lastIntKey(); final int otherLocalsLastKey = destLocals.isEmpty() ? -1 : destLocals.lastIntKey(); if (localsLastKey < otherLocalsLastKey) {