| commit | ae317aecc56c38cc0f18c57ee66ca683d5a520de | [log] [tgz] |
|---|---|---|
| author | Christoffer Quist Adamsen <christofferqa@google.com> | Thu Jan 03 10:58:02 2019 +0100 |
| committer | Christoffer Quist Adamsen <christofferqa@google.com> | Thu Jan 03 10:58:02 2019 +0100 |
| tree | 96fd084caf2ae9a28e5143ea89a7b6931d59c387 | |
| parent | f37576e5c4a0fc5aaa4a4a68d385c8e4399b29e8 [diff] |
Allow storing arbitrary class types in fields with an interface type This CL updates the type checker to accept field-assignments where an object of class type C is assigned to a field that has interface type I and C is not a subtype of I. This is needed since interface types are treated like Object according to the JVM specification (https://docs.oracle.com/javase/specs/jvms/se9/html/jvms-4.html#jvms-4.10.1.2-100). Prior to this CL, the body of methods with such instructions were replaced by "throw null". Note that, although R8 should generally not encounter such field-assignments, we have seen such code in libraries that have been shrunk with another compiler than R8. With this CL, R8 is technically still unsound. Due to assignment rules in the JVM specification, it is not safe to trust that a value that is being read from a field with interface type I actually has type I. This CL additionally extends the `InvalidTypeTest` to demonstrate that all of DX, D8, Proguard, and R8 are unsound in this regard. Bug: 120277396 Change-Id: Ic403d769d26adab3a5cc3e30cb7e9f24e2cd41dd
The R8 repo contains two tools:
D8 is a replacement for the DX dexer and R8 is a replacement for the Proguard shrinking and minification tool.
The R8 project uses depot_tools from the chromium project to manage dependencies. Install depot_tools and add it to your path before proceeding.
The R8 project uses Java 8 language features and requires a Java 8 compiler and runtime system.
Typical steps to download and build:
$ git clone https://r8.googlesource.com/r8 $ cd r8 $ tools/gradle.py d8 r8
The tools/gradle.py script will bootstrap using depot_tools to download a version of gradle to use for building on the first run. This will produce two jar files: build/libs/d8.jar and build/libs/r8.jar.
The D8 dexer has a simple command-line interface with only a few options.
The most important option is whether to build in debug or release mode. Debug is the default mode and includes debugging information in the resulting dex files. Debugging information contains information about local variables used when debugging dex code. This information is not useful when shipping final Android apps to users and therefore, final builds should use the --release flag to remove this debugging information to produce smaller dex files.
Typical invocations of D8 to produce dex file(s) in the out directoy:
Debug mode build:
$ java -jar build/libs/d8.jar --output out input.jar
Release mode build:
$ java -jar build/libs/d8.jar --release --output out input.jar
The full set of D8 options can be obtained by running the command line tool with the --help option.
R8 is a Proguard replacement for whole-program optimization, shrinking and minification. R8 uses the Proguard keep rule format for specifying the entry points for an application.
Typical invocations of R8 to produce optimized dex file(s) in the out directory:
$ java -jar build/libs/r8.jar --release --output out --pg-conf proguard.cfg input.jar
The full set of R8 options can be obtained by running the command line tool with the --help option.
Typical steps to run tests:
$ tools/test.py --no_internal
The tools/test.py script will use depot_tools to download a lot of tests and test dependencies on the first run. This includes prebuilt version of the art runtime on which to validate the produced dex code.
In order to contribute to D8/R8 you have to sign the Contributor License Agreement. If your contribution is owned by your employer you need the Corporate Contributor License Agreement.
Once the license agreement is in place, you can upload your patches using ‘git cl’ which is available in depot_tools. Once you have a change that you are happy with you should make sure that it passes all tests and then upload the change to our code review tool using:
$ git cl upload
On your first upload you will be asked to acquire credentials. Follow the instructions given by git cl upload.
On successful uploads a link to the code review is printed in the output of the upload command. In the code review tool you can assign reviewers and mark the change ready for review. At that point the code review tool will send emails to reviewers.
For questions, reach out to us at r8-dev@googlegroups.com.
For D8, find known issues in the D8 issue tracker or file a new D8 bug report.
For R8, find known issues in the R8 issue tracker or file a new R8 bug report.