commit | b7cb52c6c330a7d232a68220121f7cd74498f912 | [log] [tgz] |
---|---|---|
author | Denis Vnukov <vnukov@google.com> | Wed Jun 27 10:26:41 2018 -0700 |
committer | Denis Vnukov <vnukov@google.com> | Wed Jun 27 10:26:41 2018 -0700 |
tree | f88b2003b93db1d8f6b1dcfe45836d867b5d1086 | |
parent | 1e7c53e257807e4a7f3c40633aceff5823af02f0 [diff] |
Support kotlin k-style lambdas in class inliner Extending class inliner to support k-style lambdas. The only significant change is that now classes not directly extending java.lang.Object can be considered eligible for inlining. This is achieved by very restrictive rules for classes not directly inherited from java.lang.Object, which is still wide enough to allow k-style lambdas to become eligible. This CL also includes following improvements: -- hints for kotlin method parameters suggesting they are not-null and, thus, checked inside the method for nullability; those checks will be removed after inlining if we know that we pass non-null argument. Note that these hints don't affect semantics and only used for inlining heuristics (see b/72972159) -- based on previous work we can now mark *some* singleton instance field reads as always returning non-null value -- fix propagation of never null flag via values. This is a temp solution I needed to make some things work, and AFAIK Jinseong is going to improve nullability handling soon GMSCORE (no time impact): w/o: 28,543,136 w: 28,537,188 (-6K) Bug: 80135269 Bug: 72972159 Change-Id: Ifcae9fe13cefaea7a10a7abd3d80983dd090b505
The R8 repo contains two tools:
D8 is a replacement for the DX dexer and R8 is a replacement for the Proguard shrinking and minification tool.
The R8 project uses depot_tools
from the chromium project to manage dependencies. Install depot_tools
and add it to your path before proceeding.
The R8 project uses Java 8 language features and requires a Java 8 compiler and runtime system.
Typical steps to download and build:
$ git clone https://r8.googlesource.com/r8 $ cd r8 $ tools/gradle.py d8 r8
The tools/gradle.py
script will bootstrap using depot_tools to download a version of gradle to use for building on the first run. This will produce two jar files: build/libs/d8.jar
and build/libs/r8.jar
.
The D8 dexer has a simple command-line interface with only a few options.
The most important option is whether to build in debug or release mode. Debug is the default mode and includes debugging information in the resulting dex files. Debugging information contains information about local variables used when debugging dex code. This information is not useful when shipping final Android apps to users and therefore, final builds should use the --release
flag to remove this debugging information to produce smaller dex files.
Typical invocations of D8 to produce dex file(s) in the out directoy:
Debug mode build:
$ java -jar build/libs/d8.jar --output out input.jar
Release mode build:
$ java -jar build/libs/d8.jar --release --output out input.jar
The full set of D8 options can be obtained by running the command line tool with the --help
option.
R8 is a Proguard replacement for whole-program optimization, shrinking and minification. R8 uses the Proguard keep rule format for specifying the entry points for an application.
Typical invocations of R8 to produce optimized dex file(s) in the out directory:
$ java -jar build/libs/r8.jar --release --output out --pg-conf proguard.cfg input.jar
The full set of R8 options can be obtained by running the command line tool with the --help
option.
Typical steps to run tests:
$ tools/test.py --no_internal
The tools/test.py
script will use depot_tools to download a lot of tests and test dependencies on the first run. This includes prebuilt version of the art runtime on which to validate the produced dex code.
In order to contribute to D8/R8 you have to sign the Contributor License Agreement. If your contribution is owned by your employer you need the Corporate Contributor License Agreement.
Once the license agreement is in place, you can upload your patches using ‘git cl’ which is available in depot_tools. Once you have a change that you are happy with you should make sure that it passes all tests and then upload the change to our code review tool using:
$ git cl upload
On your first upload you will be asked to acquire credentials. Follow the instructions given by git cl upload
.
On successful uploads a link to the code review is printed in the output of the upload command. In the code review tool you can assign reviewers and mark the change ready for review. At that point the code review tool will send emails to reviewers.
For questions, reach out to us at r8-dev@googlegroups.com.
For D8, find known issues in the D8 issue tracker or file a new D8 bug report.
For R8, find known issues in the R8 issue tracker or file a new R8 bug report.