Revert "Collect synthetic inputs in R8" This reverts commit cb6f2dd31b17a5a3afe3a8b3054ca1cd62df2cfc. Reason for revert: Breaks traceMainDexList004 Change-Id: I1f8c48c98d537c58cd78ace33261e29854ddf6d2
diff --git a/src/main/java/com/android/tools/r8/R8.java b/src/main/java/com/android/tools/r8/R8.java index 8a4c9cc..546fad4 100644 --- a/src/main/java/com/android/tools/r8/R8.java +++ b/src/main/java/com/android/tools/r8/R8.java
@@ -103,7 +103,6 @@ import com.android.tools.r8.shaking.VerticalClassMergerGraphLens; import com.android.tools.r8.shaking.WhyAreYouKeepingConsumer; import com.android.tools.r8.synthesis.SyntheticFinalization; -import com.android.tools.r8.synthesis.SyntheticItems; import com.android.tools.r8.utils.AndroidApiLevel; import com.android.tools.r8.utils.AndroidApp; import com.android.tools.r8.utils.CfgPrinter; @@ -292,7 +291,6 @@ appView = AppView.createForR8(application, mainDexInfo); appView.setAppServices(AppServices.builder(appView).build()); - SyntheticItems.collectSyntheticInputs(appView); } // Check for potentially having pass-through of Cf-code for kotlin libraries.
diff --git a/src/main/java/com/android/tools/r8/graph/AppView.java b/src/main/java/com/android/tools/r8/graph/AppView.java index 1cd36de..7321cc0 100644 --- a/src/main/java/com/android/tools/r8/graph/AppView.java +++ b/src/main/java/com/android/tools/r8/graph/AppView.java
@@ -558,10 +558,6 @@ return true; } - public boolean hasClassHierarchy() { - return appInfo().hasClassHierarchy(); - } - @SuppressWarnings("unchecked") public AppView<AppInfoWithClassHierarchy> withClassHierarchy() { return appInfo.hasClassHierarchy() @@ -569,12 +565,6 @@ : null; } - @SuppressWarnings("unchecked") - public AppView<AppInfo> withoutClassHierarchy() { - assert !hasClassHierarchy(); - return (AppView<AppInfo>) this; - } - public boolean hasLiveness() { return appInfo().hasLiveness(); }
diff --git a/src/main/java/com/android/tools/r8/synthesis/SyntheticItems.java b/src/main/java/com/android/tools/r8/synthesis/SyntheticItems.java index 86bca3a..d6c93aa 100644 --- a/src/main/java/com/android/tools/r8/synthesis/SyntheticItems.java +++ b/src/main/java/com/android/tools/r8/synthesis/SyntheticItems.java
@@ -109,7 +109,7 @@ this.committed = committed; } - public static void collectSyntheticInputs(AppView<?> appView) { + public static void collectSyntheticInputs(AppView<AppInfo> appView) { // Collecting synthetic items must be the very first task after application build. SyntheticItems synthetics = appView.getSyntheticItems(); assert synthetics.nextSyntheticId == 0; @@ -143,15 +143,7 @@ CommittedItems commit = new CommittedItems( synthetics.nextSyntheticId, appView.appInfo().app(), committed, ImmutableList.of()); - if (appView.appInfo().hasClassHierarchy()) { - appView - .withClassHierarchy() - .setAppInfo(appView.appInfo().withClassHierarchy().rebuildWithClassHierarchy(commit)); - } else { - appView - .withoutClassHierarchy() - .setAppInfo(new AppInfo(commit, appView.appInfo().getMainDexInfo())); - } + appView.setAppInfo(new AppInfo(commit, appView.appInfo().getMainDexInfo())); } // Predicates and accessors.