commit c374cc5e22adb7ba54de5aa21f8147070ae3fbd0
author Søren Gjesse <sgjesse@google.com> Tue Jan 21 16:37:33 2025 +0100
committer Søren Gjesse <sgjesse@google.com> Thu Jan 23 01:45:16 2025 -0800
tree d670b4e0618e9782d1717d0e3d16cbb63937c996
parent c7ee517708226d68cc61a9ca398c9939ffa738d1

Don't rely on assertions for validating api-version.xml

Change-Id: Ie8953fd67f2d0b4fff60f5261b8d57cacfce74c8

src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java

diff --git a/src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java b/src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java
index 5f52832..6c6e251 100644
--- a/src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java
+++ b/src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java
@@ -5,6 +5,8 @@
 package com.android.tools.r8.apimodel;
 
 import static com.android.tools.r8.utils.FunctionUtils.ignoreArgument;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
 
 import com.android.tools.r8.references.ClassReference;
 import com.android.tools.r8.references.FieldReference;
@@ -115,29 +117,25 @@
   }
 
   private void readApiVersionsXmlFile() throws Exception {
-    boolean assertionsEnabled = false;
-    assert assertionsEnabled = true;
-    if (!assertionsEnabled) {
-      throw new Exception(
-          "Always run the api-versions.xml parser with assertions enabled. Format checks are based"
-              + " on assertions.");
-    }
     CodeInspector inspector = new CodeInspector(androidJar);
     DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
     Document document = factory.newDocumentBuilder().parse(apiVersionsXml.toFile());
     NodeList api = document.getElementsByTagName("api");
-    assert api.getLength() == 1;
-    assert api.item(0).getNodeType() == Node.ELEMENT_NODE;
-    assert api.item(0).getAttributes().getNamedItem("version") != null;
+    assertTrue(
+        "Expected exactly one <api> element",
+        api.getLength() == 1 && api.item(0).getNodeType() == Node.ELEMENT_NODE);
+    assertTrue(
+        "Expected 'version' attribute",
+        api.item(0).getAttributes().getNamedItem("version") != null);
     String versionString = api.item(0).getAttributes().getNamedItem("version").getNodeValue();
     int version = Integer.parseInt(versionString);
     // Only versions 3 and 4 of api-versions.xml are supported.
-    assert version == 3 || version == 4;
+    assertTrue("Only version 3 and 4 are supported", version == 3 || version == 4);
     NodeList classes = document.getElementsByTagName("class");
     Set<String> exemptionList = getDeletedTypesMissingRemovedAttribute();
     for (int i = 0; i < classes.getLength(); i++) {
       Node node = classes.item(i);
-      assert node.getNodeType() == Node.ELEMENT_NODE;
+      assertSame("Expected <class> to be an element", node.getNodeType(), Node.ELEMENT_NODE);
       AndroidApiLevel apiLevel = getMaxAndroidApiLevelFromNode(node, version, AndroidApiLevel.B);
       String type = DescriptorUtils.getJavaTypeFromBinaryName(getName(node));
       ClassSubject clazz = inspector.clazz(type);