commit | c96d2419b8c4dd316e7af9d9a4cbdf0d4410e097 | [log] [tgz] |
---|---|---|
author | Morten Krogh-Jespersen <mkroghj@google.com> | Thu Mar 07 10:35:12 2019 +0100 |
committer | Morten Krogh-Jespersen <mkroghj@google.com> | Thu Mar 07 10:35:12 2019 +0100 |
tree | 24aa068d503469cc0ab2b28c5a07f5c51c4192a8 | |
parent | 5bece707f8a08481f28b991a8936f76a5dce3221 [diff] |
Split applymapping tests into source and shrunken library This CL prepares tests for a fix to using applymapping with a proguard mapping file for naming output where the library is either provided as program source or library, but unobfuscated. Almost all tests are relevant for the use case where the library is obfuscated, thus we duplicate tests. The logic has changed in the following tests: InnerEnumValuesTest ------------------- This test assumed that when renaming enum-values that the backing string would also be renamed. Thus, if we have: enum { STATE_X, STATE_Y } and map: STATE_X -> a STATE_Y -> y the test would assert that: system.out.print(STATE_X).equals("a") We should generally not change the backing name in strings of enum values. MemberResolutionAsmTest ----------------------- This tests that: public class A { public void foo() { ... } } public class B extends A { private void foo() { ... } } and a mapping file: A.foo -> a; what should happen to B.foo. Notice that this code does not compile and only happens if one links against libraries where methods has been made private or if the code is manually written or created with separate compilation. In this case, one probably named foo to give it exactly the same name as the base method. The test is changed to then expect B.foo to be renamed to a. WhenToApplyTest --------------- This test tested what would happen if a mapping file was given with applymapping and we have minification enabled. Given a mapping file means that one gives an explicit map for how all types should be named, so this test no longer applies. Nothing in this test was not tested elsewhere so it has been removed. Bug: 126503704 Bug: 123092153 Bug: 121305642 Change-Id: Ida14467eabc0f35a8b50cbe3938bccbe3be93cf9
The R8 repo contains two tools:
D8 is a replacement for the DX dexer and R8 is a replacement for the Proguard shrinking and minification tool.
The R8 project uses depot_tools
from the chromium project to manage dependencies. Install depot_tools
and add it to your path before proceeding.
The R8 project uses Java 8 language features and requires a Java 8 compiler and runtime system.
Typical steps to download and build:
$ git clone https://r8.googlesource.com/r8 $ cd r8 $ tools/gradle.py d8 r8
The tools/gradle.py
script will bootstrap using depot_tools to download a version of gradle to use for building on the first run. This will produce two jar files: build/libs/d8.jar
and build/libs/r8.jar
.
The D8 dexer has a simple command-line interface with only a few options.
The most important option is whether to build in debug or release mode. Debug is the default mode and includes debugging information in the resulting dex files. Debugging information contains information about local variables used when debugging dex code. This information is not useful when shipping final Android apps to users and therefore, final builds should use the --release
flag to remove this debugging information to produce smaller dex files.
Typical invocations of D8 to produce dex file(s) in the out directoy:
Debug mode build:
$ java -jar build/libs/d8.jar --output out input.jar
Release mode build:
$ java -jar build/libs/d8.jar --release --output out input.jar
The full set of D8 options can be obtained by running the command line tool with the --help
option.
R8 is a Proguard replacement for whole-program optimization, shrinking and minification. R8 uses the Proguard keep rule format for specifying the entry points for an application.
Typical invocations of R8 to produce optimized dex file(s) in the out directory:
$ java -jar build/libs/r8.jar --release --output out --pg-conf proguard.cfg input.jar
The full set of R8 options can be obtained by running the command line tool with the --help
option.
Typical steps to run tests:
$ tools/test.py --no_internal
The tools/test.py
script will use depot_tools to download a lot of tests and test dependencies on the first run. This includes prebuilt version of the art runtime on which to validate the produced dex code.
In order to contribute to D8/R8 you have to sign the Contributor License Agreement. If your contribution is owned by your employer you need the Corporate Contributor License Agreement.
Once the license agreement is in place, you can upload your patches using ‘git cl’ which is available in depot_tools. Once you have a change that you are happy with you should make sure that it passes all tests and then upload the change to our code review tool using:
$ git cl upload
On your first upload you will be asked to acquire credentials. Follow the instructions given by git cl upload
.
On successful uploads a link to the code review is printed in the output of the upload command. In the code review tool you can assign reviewers and mark the change ready for review. At that point the code review tool will send emails to reviewers.
For questions, reach out to us at r8-dev@googlegroups.com.
For D8, find known issues in the D8 issue tracker or file a new D8 bug report.
For R8, find known issues in the R8 issue tracker or file a new R8 bug report.