Desugaring library conversion error
- Desugared library conversion raise
incorrect errors at runtime when
used on low API level.
Bug: 143275651
Change-Id: I3cb5ebcb9301b16a8167dc91d8c9e8cdda9a09fa
diff --git a/src/test/java/com/android/tools/r8/desugar/corelib/conversionTests/ConversionErrorMessageTest.java b/src/test/java/com/android/tools/r8/desugar/corelib/conversionTests/ConversionErrorMessageTest.java
new file mode 100644
index 0000000..9be1f56
--- /dev/null
+++ b/src/test/java/com/android/tools/r8/desugar/corelib/conversionTests/ConversionErrorMessageTest.java
@@ -0,0 +1,139 @@
+// Copyright (c) 2019, the R8 project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+package com.android.tools.r8.desugar.corelib.conversionTests;
+
+import com.android.tools.r8.TestParameters;
+import com.android.tools.r8.TestParametersCollection;
+import com.android.tools.r8.utils.AndroidApiLevel;
+import com.android.tools.r8.utils.StringUtils;
+import java.util.Arrays;
+import java.util.function.IntUnaryOperator;
+import org.junit.Assume;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
+
+@RunWith(Parameterized.class)
+public class ConversionErrorMessageTest extends APIConversionTestBase {
+
+ private final TestParameters parameters;
+
+ @Parameters(name = "{0}")
+ public static TestParametersCollection data() {
+ return getTestParameters().withAllRuntimesAndApiLevels().build();
+ }
+
+ public ConversionErrorMessageTest(TestParameters parameters) {
+ this.parameters = parameters;
+ }
+
+ public String getExpectedResult() {
+ if (hasRequiredAPI()) {
+ // On Cf or high device API levels, the call succeeds.
+ return StringUtils.lines("npe", "null", "success");
+ }
+ // On low device API levels, the call fails, but the error message is different on Dalvik.
+ String msg;
+ if (parameters.getRuntime().asDex().getMinApiLevel().getLevel()
+ < AndroidApiLevel.L.getLevel()) {
+ msg = "java.util.Arrays.setAll";
+ } else {
+ msg =
+ "No static method setAll([ILjava/util/function/IntUnaryOperator;)V in class"
+ + " Ljava/util/Arrays; or its super classes (declaration of 'java.util.Arrays'"
+ + " appears in out/host/linux-x86/framework/core-libart-hostdex.jar)";
+ }
+ return StringUtils.lines(
+ "noSuchMethod",
+ msg,
+ "noClassDef",
+ "com.android.tools.r8.desugar.corelib.conversionTests."
+ + "ConversionErrorMessageTest$MyIntUnaryOperator");
+
+ }
+
+ private boolean hasRequiredAPI() {
+ return parameters.isCfRuntime() || parameters.getRuntime().asDex().getMinApiLevel().getLevel()
+ >= AndroidApiLevel.N.getLevel();
+ }
+
+ @Test
+ public void testExceptionNoDesugaring() throws Exception {
+ testForRuntime(parameters.getRuntime(), parameters.getApiLevel())
+ .addProgramClasses(Executor.class, MyIntUnaryOperator.class)
+ .run(parameters.getRuntime(), Executor.class)
+ .assertSuccessWithOutput(getExpectedResult());
+ }
+
+ @Test
+ public void testExceptionDesugaring() throws Exception {
+ Assume.assumeTrue("CF desugaring not supported", parameters.isDexRuntime());
+ // TODO(b/143275651): Raise the right error, NoClassDefFoundError on Function or
+ // NoSuchMethodError instead of NoClassDefFoundError on the wrapper.
+ Assume.assumeTrue(hasRequiredAPI());
+ testForD8()
+ .addProgramClasses(Executor.class, MyIntUnaryOperator.class)
+ .setMinApi(parameters.getApiLevel())
+ .enableCoreLibraryDesugaring(parameters.getApiLevel())
+ .compile()
+ .addDesugaredCoreLibraryRunClassPath(
+ this::buildDesugaredLibraryWithConversionExtension, parameters.getApiLevel())
+ .run(parameters.getRuntime(), Executor.class)
+ .assertSuccessWithOutput(getExpectedResult());
+ }
+
+ @SuppressWarnings("WeakerAccess")
+ static class Executor {
+
+ public static void main(String[] args) {
+ noSuchMethod();
+ noClassDef();
+ }
+
+ @SuppressWarnings({"ConstantConditions", "MismatchedReadAndWriteOfArray"})
+ public static void noSuchMethod() {
+ int[] ints = new int[3];
+ try {
+ Arrays.setAll(ints, null);
+ System.out.println("success");
+ } catch (NoClassDefFoundError ex) {
+ System.out.println("noClassDef");
+ System.out.println(ex.getMessage());
+ } catch (NoSuchMethodError ex) {
+ System.out.println("noSuchMethod");
+ System.out.println(ex.getMessage());
+ } catch (NullPointerException ex) {
+ System.out.println("npe");
+ System.out.println(ex.getMessage());
+ }
+ }
+
+ @SuppressWarnings({"MismatchedReadAndWriteOfArray"})
+ public static void noClassDef() {
+ int[] ints = new int[3];
+ try {
+ Arrays.setAll(ints, new MyIntUnaryOperator());
+ System.out.println("success");
+ } catch (NoClassDefFoundError ex) {
+ System.out.println("noClassDef");
+ System.out.println(ex.getMessage());
+ } catch (NoSuchMethodError ex) {
+ System.out.println("noSuchMethod");
+ System.out.println(ex.getMessage());
+ } catch (NullPointerException ex) {
+ System.out.println("npe");
+ System.out.println(ex.getMessage());
+ }
+ }
+ }
+
+ static class MyIntUnaryOperator implements IntUnaryOperator {
+
+ public int applyAsInt(int x) {
+ return x + 1;
+ }
+ }
+}
