commit e10d3bb897990d44683e7520ea9c021efa7ea08a
author Ian Zerny <zerny@google.com> Thu Sep 02 08:54:15 2021 +0200
committer Ian Zerny <zerny@google.com> Thu Sep 02 07:52:13 2021 +0000
tree e8a1f3296f3a808e2ea0826add320b2b3ccd4347
parent 5b1c26c9a6ee9db791178d96b1712568ad8cc3fd

Only run against retrace.jar when testing r8 lib.

Change-Id: I14211ef9ee7f35ded2982589c4c5abcfb99a6248

src/test/java/com/android/tools/r8/retrace/api/RetraceApiBinaryCompatibilityTest.java

diff --git a/src/test/java/com/android/tools/r8/retrace/api/RetraceApiBinaryCompatibilityTest.java b/src/test/java/com/android/tools/r8/retrace/api/RetraceApiBinaryCompatibilityTest.java
index df7c599..6d9c328 100644
--- a/src/test/java/com/android/tools/r8/retrace/api/RetraceApiBinaryCompatibilityTest.java
+++ b/src/test/java/com/android/tools/r8/retrace/api/RetraceApiBinaryCompatibilityTest.java
@@ -63,8 +63,10 @@
       assertNotEquals(0, existing.size());
       for (Path classFile : generated) {
         Path otherClassFile = binaryContents.resolve(generatedContents.relativize(classFile));
-        assertTrue(Files.exists(otherClassFile));
-        assertTrue(TestBase.filesAreEqual(classFile, otherClassFile));
+        assertTrue("Could not find file: " + otherClassFile, Files.exists(otherClassFile));
+        assertTrue(
+            "Non-equal files: " + otherClassFile,
+            TestBase.filesAreEqual(classFile, otherClassFile));
       }
     }
   }
@@ -75,10 +77,12 @@
 
   @Test
   public void runCheckedInBinaryJar() throws Exception {
+    // The retrace jar is only built when building r8lib.
+    Path jar = ToolHelper.isTestingR8Lib() ? ToolHelper.R8_RETRACE_JAR : ToolHelper.R8_JAR;
     for (CfRuntime cfRuntime : CfRuntime.getCheckedInCfRuntimes()) {
       RetraceApiTestHelper.runJunitOnTests(
           cfRuntime,
-          ToolHelper.R8_RETRACE_JAR,
+          jar,
           BINARY_COMPATIBILITY_JAR,
           RetraceApiTestHelper.getBinaryCompatibilityTests());
     }

src/test/java/com/android/tools/r8/retrace/api/RetraceApiTestHelper.java

diff --git a/src/test/java/com/android/tools/r8/retrace/api/RetraceApiTestHelper.java b/src/test/java/com/android/tools/r8/retrace/api/RetraceApiTestHelper.java
index a1049f1..7f9834b 100644
--- a/src/test/java/com/android/tools/r8/retrace/api/RetraceApiTestHelper.java
+++ b/src/test/java/com/android/tools/r8/retrace/api/RetraceApiTestHelper.java
@@ -63,7 +63,7 @@
             classPaths,
             "org.junit.runner.JUnitCore",
             StringUtils.join(" ", tests, Class::getTypeName));
-    assertEquals(0, processResult.exitCode);
+    assertEquals(processResult.toString(), 0, processResult.exitCode);
     assertThat(processResult.stdout, containsString("OK (" + tests.size() + " test"));
   }