Add TODO for investigating a fix for partial rewriting
Bug: b/336170435
Change-Id: Ieebcb22bcb3526e41ddde27660cccc2394c44b4d
diff --git a/src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java b/src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
index c425cb7..e72d7ec 100644
--- a/src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
+++ b/src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
@@ -27,6 +27,10 @@
public class SplitBranch extends CodeRewriterPass<AppInfo> {
+ // Partial rewriting is not sound as it may change the dominator tree such that a rewritten phi
+ // usage is not dominated by the definition of the operand. The issue reproduces with the dump
+ // attached in b/334275655#comment12.
+ // TODO(b/336170435): Consider if the rewriting should be fixed and enabled again.
private static final boolean ALLOW_PARTIAL_REWRITE = false;
public SplitBranch(AppView<?> appView) {
