commit 1df8f4c01ca62feb63c935d1950128bc6bb22ada
author Christoffer Quist Adamsen <christofferqa@google.com> Thu Oct 10 15:20:48 2019 +0200
committer Christoffer Quist Adamsen <christofferqa@google.com> Sat Oct 12 08:40:13 2019 +0000
tree 123026d401a55016582b56ffd4a0e900feeafd88
parent 50d4852375d4a71ff12080ddbc1a5a69caefd86e

Use that no lambda classes are synthesized during wave processing in R8

Bug: 142233246
Change-Id: Ifb605376adab2c5018c0d32b5ee6011ec6828a36

src/main/java/com/android/tools/r8/ir/desugar/LambdaRewriter.java

diff --git a/src/main/java/com/android/tools/r8/ir/desugar/LambdaRewriter.java b/src/main/java/com/android/tools/r8/ir/desugar/LambdaRewriter.java
index 9cc26c4..dfb1787 100644
--- a/src/main/java/com/android/tools/r8/ir/desugar/LambdaRewriter.java
+++ b/src/main/java/com/android/tools/r8/ir/desugar/LambdaRewriter.java
@@ -156,8 +156,12 @@
             continue;
           }
 
-          // We have a descriptor, get or create lambda class.
-          LambdaClass lambdaClass = getOrCreateLambdaClass(descriptor, currentType);
+          // We have a descriptor, get the lambda class. In D8, we synthesize the lambda classes
+          // during IR processing, and therefore we may need to create it now.
+          LambdaClass lambdaClass =
+              appView.enableWholeProgramOptimizations()
+                  ? getKnownLambdaClass(descriptor, currentType)
+                  : getOrCreateLambdaClass(descriptor, currentType);
           assert lambdaClass != null;
 
           // We rely on patch performing its work in a way which
@@ -325,6 +329,11 @@
     return lambdaClass;
   }
 
+  private LambdaClass getKnownLambdaClass(LambdaDescriptor descriptor, DexType accessedFrom) {
+    DexType lambdaClassType = LambdaClass.createLambdaClassType(this, accessedFrom, descriptor);
+    return getKnown(knownLambdaClasses, lambdaClassType);
+  }
+
   private void addRewritingPrefix(DexType type, DexType rewritten, DexType lambdaClassType) {
     String javaName = lambdaClassType.toString();
     String typeString = type.toString();