commit 54921aedfdcc1fe1e3ab5da55c060043ba109faa
author Mads Ager <ager@google.com> Thu Oct 12 09:42:24 2017 +0200
committer Mads Ager <ager@google.com> Thu Oct 12 07:45:29 2017 +0000
tree b634a6af49e0b4dd0f962419d46982134a4b09d7
parent 96f6c2187bf880a1de184a531def94cfa4ff3e42

Version 0.1.17.

Merge: Fix infinite loop in register allocator.
CL: https://r8-review.googlesource.com/c/r8/+/8440

Change-Id: I8c37e48d5a185bc30b7ed876e3e52e5a8e55009c

src/main/java/com/android/tools/r8/D8.java

diff --git a/src/main/java/com/android/tools/r8/D8.java b/src/main/java/com/android/tools/r8/D8.java
index f4b3c8d..5a97375 100644
--- a/src/main/java/com/android/tools/r8/D8.java
+++ b/src/main/java/com/android/tools/r8/D8.java
@@ -55,7 +55,7 @@
  */
 public final class D8 {
 
-  private static final String VERSION = "v0.1.16";
+  private static final String VERSION = "v0.1.17";
   private static final int STATUS_ERROR = 1;
 
   private D8() {}

src/main/java/com/android/tools/r8/R8.java

diff --git a/src/main/java/com/android/tools/r8/R8.java b/src/main/java/com/android/tools/r8/R8.java
index 1fb04a6..1c248b9 100644
--- a/src/main/java/com/android/tools/r8/R8.java
+++ b/src/main/java/com/android/tools/r8/R8.java
@@ -71,7 +71,7 @@
 
 public class R8 {
 
-  private static final String VERSION = "v0.1.16";
+  private static final String VERSION = "v0.1.17";
   private final Timing timing = new Timing("R8");
   private final InternalOptions options;
 

src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java

diff --git a/src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java b/src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
index 300aece..0f43ee5 100644
--- a/src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
+++ b/src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
@@ -1374,10 +1374,18 @@
       return candidate;
     }
     if (needsOverlappingLongRegisterWorkaround(unhandledInterval)) {
+      int lastCandidate = candidate;
       while (hasOverlappingLongRegisters(unhandledInterval, candidate)) {
         // Make the overlapping register unavailable for allocation and try again.
         freePositions.set(candidate, 0);
         candidate = getLargestCandidate(registerConstraint, freePositions, needsRegisterPair, type);
+        // If there are only invalid candidates of the give type we will end up with the same
+        // candidate returned again once we have tried them all. In that case we didn't find a
+        // valid register candidate and we need to broaden the search to other types.
+        if (lastCandidate == candidate) {
+          return REGISTER_CANDIDATE_NOT_FOUND;
+        }
+        lastCandidate = candidate;
       }
     }
     return candidate;