commit 8ced190fc454c403506a296fbb0f04391f2e36fe
author Jinseong Jeon <jsjeon@google.com> Fri Apr 19 10:30:12 2019 -0700
committer Jinseong Jeon <jsjeon@google.com> Wed Apr 24 16:46:54 2019 +0000
tree 1059980b6a24964c421c31a0d357cbb5e0d5e400
parent 0c0e043d8795e2091716f5328d0586878ca17d79

Test parsing keepattribute with a class name.

Bug: 130746806
Change-Id: Ia7a1c1054997ca1680587b556dcd4fbbde9a74b9

src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java

diff --git a/src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java b/src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java
index d0fb723..ea5c72d 100644
--- a/src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java
+++ b/src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java
@@ -1350,7 +1350,7 @@
   }
 
   @Test
-  public void parseInvalidKeepattributes() {
+  public void parseInvalidKeepattributes_brokenList() {
     try {
       ProguardConfigurationParser parser =
           new ProguardConfigurationParser(new DexItemFactory(), reporter);
@@ -1363,6 +1363,21 @@
   }
 
   @Test
+  public void parseInvalidKeepattributes_className() {
+    try {
+      ProguardConfigurationParser parser =
+          new ProguardConfigurationParser(new DexItemFactory(), reporter);
+      parser.parse(createConfigurationForTesting(
+          ImmutableList.of("-keepattributes androidx.annotation.Keep")));
+      fail();
+    } catch (AbortException e) {
+      // TODO(b/130746806): better error message?
+      assertTrue(
+          handler.errors.get(0).getDiagnosticMessage().contains("Expected char '-' at "));
+    }
+  }
+
+  @Test
   public void parseUseUniqueClassMemberNames() throws IOException {
     Path proguardConfig = writeTextToTempFile("-useuniqueclassmembernames");
     new ProguardConfigurationParser(new DexItemFactory(), reporter).parse(proguardConfig);