Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 1 | # Copyright (c) 2018, the R8 project authors. Please see the AUTHORS file |
| 2 | # for details. All rights reserved. Use of this source code is governed by a |
| 3 | # BSD-style license that can be found in the LICENSE file. |
| 4 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 5 | from os import path |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 6 | import datetime |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 7 | from subprocess import check_output, Popen, PIPE, STDOUT |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 8 | |
| 9 | FMT_CMD = path.join( |
| 10 | 'third_party', |
Christoffer Quist Adamsen | bfe52fd | 2022-02-15 14:32:52 +0100 | [diff] [blame] | 11 | 'google', |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 12 | 'google-java-format', |
Christoffer Quist Adamsen | bfe52fd | 2022-02-15 14:32:52 +0100 | [diff] [blame] | 13 | '1.14.0', |
| 14 | 'google-java-format-1.14.0', |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 15 | 'scripts', |
| 16 | 'google-java-format-diff.py') |
| 17 | |
Søren Gjesse | ffc0619 | 2022-06-03 11:11:27 +0200 | [diff] [blame] | 18 | FMT_CMD_JDK17 = path.join('tools','google-java-format-diff.py') |
| 19 | |
| 20 | |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 21 | def CheckDoNotMerge(input_api, output_api): |
| 22 | for l in input_api.change.FullDescriptionText().splitlines(): |
| 23 | if l.lower().startswith('do not merge'): |
| 24 | msg = 'Your cl contains: \'Do not merge\' - this will break WIP bots' |
| 25 | return [output_api.PresubmitPromptWarning(msg, [])] |
| 26 | return [] |
| 27 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 28 | def CheckFormatting(input_api, output_api, branch): |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 29 | results = [] |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 30 | for f in input_api.AffectedFiles(): |
| 31 | path = f.LocalPath() |
| 32 | if not path.endswith('.java'): |
| 33 | continue |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 34 | diff = check_output( |
| 35 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 36 | proc = Popen(FMT_CMD, stdin=PIPE, stdout=PIPE, stderr=STDOUT) |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 37 | (stdout, stderr) = proc.communicate(input=diff) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 38 | if len(stdout) > 0: |
| 39 | results.append(output_api.PresubmitError(stdout)) |
| 40 | if len(results) > 0: |
| 41 | results.append(output_api.PresubmitError( |
| 42 | """Please fix the formatting by running: |
| 43 | |
| 44 | git diff -U0 $(git cl upstream) | %s -p1 -i |
| 45 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 46 | or fix formatting, commit and upload: |
| 47 | |
| 48 | git diff -U0 $(git cl upstream) | %s -p1 -i && git commit -a --amend --no-edit && git cl upload |
| 49 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 50 | or bypass the checks with: |
| 51 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 52 | git cl upload --bypass-hooks |
Søren Gjesse | ffc0619 | 2022-06-03 11:11:27 +0200 | [diff] [blame] | 53 | |
| 54 | If formatting fails with 'No enum constant javax.lang.model.element.Modifier.SEALED' try |
| 55 | |
| 56 | git diff -U0 $(git cl upstream) | %s %s %s -p1 -i && git commit -a --amend --no-edit && git cl upload |
| 57 | """ % ( |
| 58 | FMT_CMD, |
| 59 | FMT_CMD, |
| 60 | FMT_CMD_JDK17, |
| 61 | '--google-java-format-jar', |
| 62 | 'third_party/google/google-java-format/1.14.0/google-java-format-1.14.0-all-deps.jar' |
| 63 | ))) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 64 | return results |
| 65 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 66 | def CheckDeterministicDebuggingChanged(input_api, output_api, branch): |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 67 | for f in input_api.AffectedFiles(): |
| 68 | path = f.LocalPath() |
| 69 | if not path.endswith('InternalOptions.java'): |
| 70 | continue |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 71 | diff = check_output( |
| 72 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
| 73 | if 'DETERMINISTIC_DEBUGGING' in diff: |
| 74 | return [output_api.PresubmitError(diff)] |
| 75 | return [] |
| 76 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 77 | def CheckForAddedDisassemble(input_api, output_api): |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 78 | results = [] |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 79 | for (file, line_nr, line) in input_api.RightHandSideLines(): |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 80 | if file.LocalPath().endswith('.java') and '.disassemble()' in line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 81 | results.append( |
| 82 | output_api.PresubmitError( |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 83 | 'Test call to disassemble\n%s:%s %s' % (file.LocalPath(), line_nr, line))) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 84 | return results |
| 85 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 86 | def CheckForCopyRight(input_api, output_api, branch): |
| 87 | results = [] |
| 88 | for f in input_api.AffectedSourceFiles(None): |
| 89 | # Check if it is a new file. |
| 90 | if f.OldContents(): |
| 91 | continue |
| 92 | contents = f.NewContents() |
| 93 | if (not contents) or (len(contents) == 0): |
| 94 | continue |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 95 | if not CopyRightInContents(f, contents): |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 96 | results.append( |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 97 | output_api.PresubmitError('Could not find correctly formatted ' |
| 98 | 'copyright in file: %s' % f)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 99 | return results |
| 100 | |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 101 | def CopyRightInContents(f, contents): |
Søren Gjesse | 09c3dd0 | 2021-06-17 08:21:51 +0200 | [diff] [blame] | 102 | expected = '//' |
| 103 | if f.LocalPath().endswith('.py') or f.LocalPath().endswith('.sh'): |
| 104 | expected = '#' |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 105 | expected = expected + ' Copyright (c) ' + str(datetime.datetime.now().year) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 106 | for content_line in contents: |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 107 | if expected in content_line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 108 | return True |
| 109 | return False |
| 110 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 111 | def CheckChange(input_api, output_api): |
| 112 | branch = ( |
| 113 | check_output(['git', 'cl', 'upstream']) |
| 114 | .strip() |
| 115 | .replace('refs/heads/', '')) |
| 116 | results = [] |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 117 | results.extend(CheckDoNotMerge(input_api, output_api)) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 118 | results.extend(CheckFormatting(input_api, output_api, branch)) |
| 119 | results.extend( |
| 120 | CheckDeterministicDebuggingChanged(input_api, output_api, branch)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 121 | results.extend(CheckForAddedDisassemble(input_api, output_api)) |
| 122 | results.extend(CheckForCopyRight(input_api, output_api, branch)) |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 123 | return results |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 124 | |
| 125 | def CheckChangeOnCommit(input_api, output_api): |
| 126 | return CheckChange(input_api, output_api) |
| 127 | |
| 128 | def CheckChangeOnUpload(input_api, output_api): |
| 129 | return CheckChange(input_api, output_api) |