Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 1 | # Copyright (c) 2018, the R8 project authors. Please see the AUTHORS file |
| 2 | # for details. All rights reserved. Use of this source code is governed by a |
| 3 | # BSD-style license that can be found in the LICENSE file. |
| 4 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 5 | from os import path |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 6 | import datetime |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 7 | from subprocess import check_output, Popen, PIPE, STDOUT |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 8 | |
| 9 | FMT_CMD = path.join( |
| 10 | 'third_party', |
Christoffer Quist Adamsen | bfe52fd | 2022-02-15 14:32:52 +0100 | [diff] [blame] | 11 | 'google', |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 12 | 'google-java-format', |
Christoffer Quist Adamsen | bfe52fd | 2022-02-15 14:32:52 +0100 | [diff] [blame] | 13 | '1.14.0', |
| 14 | 'google-java-format-1.14.0', |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 15 | 'scripts', |
| 16 | 'google-java-format-diff.py') |
| 17 | |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 18 | def CheckDoNotMerge(input_api, output_api): |
| 19 | for l in input_api.change.FullDescriptionText().splitlines(): |
| 20 | if l.lower().startswith('do not merge'): |
| 21 | msg = 'Your cl contains: \'Do not merge\' - this will break WIP bots' |
| 22 | return [output_api.PresubmitPromptWarning(msg, [])] |
| 23 | return [] |
| 24 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 25 | def CheckFormatting(input_api, output_api, branch): |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 26 | results = [] |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 27 | for f in input_api.AffectedFiles(): |
| 28 | path = f.LocalPath() |
| 29 | if not path.endswith('.java'): |
| 30 | continue |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 31 | diff = check_output( |
| 32 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 33 | proc = Popen(FMT_CMD, stdin=PIPE, stdout=PIPE, stderr=STDOUT) |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 34 | (stdout, stderr) = proc.communicate(input=diff) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 35 | if len(stdout) > 0: |
| 36 | results.append(output_api.PresubmitError(stdout)) |
| 37 | if len(results) > 0: |
| 38 | results.append(output_api.PresubmitError( |
| 39 | """Please fix the formatting by running: |
| 40 | |
| 41 | git diff -U0 $(git cl upstream) | %s -p1 -i |
| 42 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 43 | or fix formatting, commit and upload: |
| 44 | |
| 45 | git diff -U0 $(git cl upstream) | %s -p1 -i && git commit -a --amend --no-edit && git cl upload |
| 46 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 47 | or bypass the checks with: |
| 48 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 49 | git cl upload --bypass-hooks |
| 50 | """ % (FMT_CMD, FMT_CMD))) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 51 | return results |
| 52 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 53 | def CheckDeterministicDebuggingChanged(input_api, output_api, branch): |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 54 | for f in input_api.AffectedFiles(): |
| 55 | path = f.LocalPath() |
| 56 | if not path.endswith('InternalOptions.java'): |
| 57 | continue |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 58 | diff = check_output( |
| 59 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
| 60 | if 'DETERMINISTIC_DEBUGGING' in diff: |
| 61 | return [output_api.PresubmitError(diff)] |
| 62 | return [] |
| 63 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 64 | def CheckForAddedDisassemble(input_api, output_api): |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 65 | results = [] |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 66 | for (file, line_nr, line) in input_api.RightHandSideLines(): |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 67 | if file.LocalPath().endswith('.java') and '.disassemble()' in line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 68 | results.append( |
| 69 | output_api.PresubmitError( |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 70 | 'Test call to disassemble\n%s:%s %s' % (file.LocalPath(), line_nr, line))) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 71 | return results |
| 72 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 73 | def CheckForCopyRight(input_api, output_api, branch): |
| 74 | results = [] |
| 75 | for f in input_api.AffectedSourceFiles(None): |
| 76 | # Check if it is a new file. |
| 77 | if f.OldContents(): |
| 78 | continue |
| 79 | contents = f.NewContents() |
| 80 | if (not contents) or (len(contents) == 0): |
| 81 | continue |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 82 | if not CopyRightInContents(f, contents): |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 83 | results.append( |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 84 | output_api.PresubmitError('Could not find correctly formatted ' |
| 85 | 'copyright in file: %s' % f)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 86 | return results |
| 87 | |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 88 | def CopyRightInContents(f, contents): |
Søren Gjesse | 09c3dd0 | 2021-06-17 08:21:51 +0200 | [diff] [blame] | 89 | expected = '//' |
| 90 | if f.LocalPath().endswith('.py') or f.LocalPath().endswith('.sh'): |
| 91 | expected = '#' |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 92 | expected = expected + ' Copyright (c) ' + str(datetime.datetime.now().year) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 93 | for content_line in contents: |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 94 | if expected in content_line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 95 | return True |
| 96 | return False |
| 97 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 98 | def CheckChange(input_api, output_api): |
| 99 | branch = ( |
| 100 | check_output(['git', 'cl', 'upstream']) |
| 101 | .strip() |
| 102 | .replace('refs/heads/', '')) |
| 103 | results = [] |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 104 | results.extend(CheckDoNotMerge(input_api, output_api)) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 105 | results.extend(CheckFormatting(input_api, output_api, branch)) |
| 106 | results.extend( |
| 107 | CheckDeterministicDebuggingChanged(input_api, output_api, branch)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 108 | results.extend(CheckForAddedDisassemble(input_api, output_api)) |
| 109 | results.extend(CheckForCopyRight(input_api, output_api, branch)) |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 110 | return results |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 111 | |
| 112 | def CheckChangeOnCommit(input_api, output_api): |
| 113 | return CheckChange(input_api, output_api) |
| 114 | |
| 115 | def CheckChangeOnUpload(input_api, output_api): |
| 116 | return CheckChange(input_api, output_api) |