Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 1 | # Copyright (c) 2018, the R8 project authors. Please see the AUTHORS file |
| 2 | # for details. All rights reserved. Use of this source code is governed by a |
| 3 | # BSD-style license that can be found in the LICENSE file. |
| 4 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 5 | from os import path |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 6 | import datetime |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 7 | from subprocess import check_output, Popen, PIPE, STDOUT |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 8 | |
| 9 | FMT_CMD = path.join( |
| 10 | 'third_party', |
| 11 | 'google-java-format', |
| 12 | 'google-java-format-google-java-format-1.7', |
| 13 | 'scripts', |
| 14 | 'google-java-format-diff.py') |
| 15 | |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 16 | def CheckDoNotMerge(input_api, output_api): |
| 17 | for l in input_api.change.FullDescriptionText().splitlines(): |
| 18 | if l.lower().startswith('do not merge'): |
| 19 | msg = 'Your cl contains: \'Do not merge\' - this will break WIP bots' |
| 20 | return [output_api.PresubmitPromptWarning(msg, [])] |
| 21 | return [] |
| 22 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 23 | def CheckFormatting(input_api, output_api, branch): |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 24 | results = [] |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 25 | for f in input_api.AffectedFiles(): |
| 26 | path = f.LocalPath() |
| 27 | if not path.endswith('.java'): |
| 28 | continue |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 29 | diff = check_output( |
| 30 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 31 | proc = Popen(FMT_CMD, stdin=PIPE, stdout=PIPE, stderr=STDOUT) |
Christoffer Quist Adamsen | 4411f07 | 2020-03-05 13:28:31 +0100 | [diff] [blame] | 32 | (stdout, stderr) = proc.communicate(input=diff) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 33 | if len(stdout) > 0: |
| 34 | results.append(output_api.PresubmitError(stdout)) |
| 35 | if len(results) > 0: |
| 36 | results.append(output_api.PresubmitError( |
| 37 | """Please fix the formatting by running: |
| 38 | |
| 39 | git diff -U0 $(git cl upstream) | %s -p1 -i |
| 40 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 41 | or fix formatting, commit and upload: |
| 42 | |
| 43 | git diff -U0 $(git cl upstream) | %s -p1 -i && git commit -a --amend --no-edit && git cl upload |
| 44 | |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 45 | or bypass the checks with: |
| 46 | |
Søren Gjesse | 641b9ab | 2020-10-08 13:28:37 +0200 | [diff] [blame] | 47 | git cl upload --bypass-hooks |
| 48 | """ % (FMT_CMD, FMT_CMD))) |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 49 | return results |
| 50 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 51 | def CheckDeterministicDebuggingChanged(input_api, output_api, branch): |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 52 | for f in input_api.AffectedFiles(): |
| 53 | path = f.LocalPath() |
| 54 | if not path.endswith('InternalOptions.java'): |
| 55 | continue |
Morten Krogh-Jespersen | 30d1f1b | 2020-03-26 11:39:19 +0100 | [diff] [blame] | 56 | diff = check_output( |
| 57 | ['git', 'diff', '--no-prefix', '-U0', branch, '--', path]) |
| 58 | if 'DETERMINISTIC_DEBUGGING' in diff: |
| 59 | return [output_api.PresubmitError(diff)] |
| 60 | return [] |
| 61 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 62 | def CheckForAddedDisassemble(input_api, output_api): |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 63 | results = [] |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 64 | for (file, line_nr, line) in input_api.RightHandSideLines(): |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 65 | if file.LocalPath().endswith('.java') and '.disassemble()' in line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 66 | results.append( |
| 67 | output_api.PresubmitError( |
Ian Zerny | a84bc1b | 2020-08-11 09:47:00 +0200 | [diff] [blame] | 68 | 'Test call to disassemble\n%s:%s %s' % (file.LocalPath(), line_nr, line))) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 69 | return results |
| 70 | |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 71 | def CheckForCopyRight(input_api, output_api, branch): |
| 72 | results = [] |
| 73 | for f in input_api.AffectedSourceFiles(None): |
| 74 | # Check if it is a new file. |
| 75 | if f.OldContents(): |
| 76 | continue |
| 77 | contents = f.NewContents() |
| 78 | if (not contents) or (len(contents) == 0): |
| 79 | continue |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 80 | if not CopyRightInContents(f, contents): |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 81 | results.append( |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 82 | output_api.PresubmitError('Could not find correctly formatted ' |
| 83 | 'copyright in file: %s' % f)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 84 | return results |
| 85 | |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 86 | def CopyRightInContents(f, contents): |
Søren Gjesse | 09c3dd0 | 2021-06-17 08:21:51 +0200 | [diff] [blame] | 87 | expected = '//' |
| 88 | if f.LocalPath().endswith('.py') or f.LocalPath().endswith('.sh'): |
| 89 | expected = '#' |
Morten Krogh-Jespersen | f997786 | 2021-09-14 12:36:28 +0200 | [diff] [blame] | 90 | expected = expected + ' Copyright (c) ' + str(datetime.datetime.now().year) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 91 | for content_line in contents: |
Christoffer Quist Adamsen | c1e18d6 | 2020-04-15 08:45:01 +0200 | [diff] [blame] | 92 | if expected in content_line: |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 93 | return True |
| 94 | return False |
| 95 | |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 96 | def CheckChange(input_api, output_api): |
| 97 | branch = ( |
| 98 | check_output(['git', 'cl', 'upstream']) |
| 99 | .strip() |
| 100 | .replace('refs/heads/', '')) |
| 101 | results = [] |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 102 | results.extend(CheckDoNotMerge(input_api, output_api)) |
Morten Krogh-Jespersen | ebc876f | 2020-04-01 10:58:02 +0200 | [diff] [blame] | 103 | results.extend(CheckFormatting(input_api, output_api, branch)) |
| 104 | results.extend( |
| 105 | CheckDeterministicDebuggingChanged(input_api, output_api, branch)) |
Morten Krogh-Jespersen | 3285e46 | 2020-04-01 13:10:46 +0200 | [diff] [blame] | 106 | results.extend(CheckForAddedDisassemble(input_api, output_api)) |
| 107 | results.extend(CheckForCopyRight(input_api, output_api, branch)) |
Rico Wind | 62d0320 | 2018-11-30 13:43:49 +0100 | [diff] [blame] | 108 | return results |
Ian Zerny | daac9c5 | 2020-03-03 10:57:17 +0100 | [diff] [blame] | 109 | |
| 110 | def CheckChangeOnCommit(input_api, output_api): |
| 111 | return CheckChange(input_api, output_api) |
| 112 | |
| 113 | def CheckChangeOnUpload(input_api, output_api): |
| 114 | return CheckChange(input_api, output_api) |